Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: add JSON.DEBUG.FIELDS and JSON.DEBUG.MEMORY commands #2481

Open
wants to merge 2 commits into
base: release-1.2
Choose a base branch
from
Open

Python: add JSON.DEBUG.FIELDS and JSON.DEBUG.MEMORY commands #2481

wants to merge 2 commits into from

Conversation

Muhammad-awawdi-amazon
Copy link
Collaborator

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon commented Oct 20, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2412

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon requested a review from a team as a code owner October 20, 2024 15:45
Yury-Fridlyand
Yury-Fridlyand reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry

python/python/glide/async_commands/server_modules/json.py Outdated Show resolved Hide resolved
python/python/glide/async_commands/server_modules/json.py Outdated Show resolved Hide resolved
python/python/tests/tests_server_modules/test_json.py Outdated Show resolved Hide resolved
@Muhammad-awawdi-amazon Muhammad-awawdi-amazon changed the title Python: add JSON.DEBUG command Python: add JSON.DEBUG.FIELDS and JSON.DEBUG.MEMORY commands Oct 22, 2024
@Muhammad-awawdi-amazon
Updated per Code Review Comments
34fc229 
Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
@Muhammad-awawdi-amazon
Changed Return type in documentation to match the actual return type …
58e2044 
…of the function

Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@shohamazon shohamazon Awaiting requested review from shohamazon

Assignees

@Muhammad-awawdi-amazon Muhammad-awawdi-amazon

Labels
1_2_candidate python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Muhammad-awawdi-amazon @Yury-Fridlyand